Browse Source

Raise an exception instead of returning None on error (#111)

J. Nick Koston 1 year ago
parent
commit
9014b8411f
1 changed files with 3 additions and 3 deletions
  1. 3 3
      switchbot/devices/device.py

+ 3 - 3
switchbot/devices/device.py

@@ -162,7 +162,7 @@ class SwitchbotBaseDevice:
                         self.rssi,
                         exc_info=True,
                     )
-                    return None
+                    raise
                 except CharacteristicMissingError as ex:
                     if attempt == retry:
                         _LOGGER.error(
@@ -172,7 +172,7 @@ class SwitchbotBaseDevice:
                             self.rssi,
                             exc_info=True,
                         )
-                        return None
+                        raise
 
                     _LOGGER.debug(
                         "%s: characteristic missing: %s; RSSI: %s",
@@ -189,7 +189,7 @@ class SwitchbotBaseDevice:
                             self.rssi,
                             exc_info=True,
                         )
-                        return None
+                        raise
 
                     _LOGGER.debug(
                         "%s: communication failed with:", self.name, exc_info=True