Browse Source

pylint: enable various optional checks/extensions

https://github.com/fphammerle/freesurfer-volume-reader/commit/c02a5655a6edfa5155625dd3e002f9e3a91a0635
https://github.com/fphammerle/ical2vdir/commit/3ddcbbd3e757644be6e32cf1c6135c82c845b4ab
Fabian Peter Hammerle 1 year ago
parent
commit
d551dd42bd

+ 22 - 2
.pylintrc

@@ -1,4 +1,24 @@
-[MESSAGE CONTROL]
+[MASTER]
 
-disable=missing-function-docstring,
+load-plugins=pylint.extensions.check_elif,
+             pylint.extensions.comparison_placement,
+             pylint.extensions.confusing_elif,
+             pylint.extensions.consider_ternary_expression,
+             pylint.extensions.emptystring,
+             pylint.extensions.eq_without_hash,
+             pylint.extensions.for_any_all,
+             pylint.extensions.mccabe,
+             pylint.extensions.no_self_use,
+             pylint.extensions.overlapping_exceptions,
+             pylint.extensions.private_import,
+             pylint.extensions.redefined_loop_name,
+             pylint.extensions.redefined_variable_type,
+             pylint.extensions.set_membership,
+             pylint.extensions.typing
+
+[MESSAGES CONTROL]
+
+disable=consider-alternative-union-syntax, # requires python>=3.10
+        deprecated-typing-alias, # requires python>=3.9, e.g. for dict[...]
+        missing-function-docstring,
         missing-module-docstring

+ 1 - 0
location_guessing_game_telegram_bot/__init__.py

@@ -46,6 +46,7 @@ class _Photo:
 
     @classmethod
     def from_wikimap_export(cls, data: dict) -> _Photo:
+        # pylint: disable=consider-ternary-expression; easier to read
         if isinstance(data["coordinates"], list):
             coords = data["coordinates"][0]
         else:

+ 1 - 0
tests/conftest.py

@@ -21,6 +21,7 @@ import typing
 
 import pytest
 
+# pylint: disable=import-private-name; tests
 from location_guessing_game_telegram_bot import _Photo
 
 

+ 1 - 0
tests/test_cli.py

@@ -4,6 +4,7 @@ import unittest.mock
 
 import pytest
 
+# pylint: disable=import-private-name; tests
 from location_guessing_game_telegram_bot import _main
 
 

+ 1 - 0
tests/test_photo.py

@@ -17,6 +17,7 @@
 
 import pytest
 
+# pylint: disable=import-private-name; tests
 from location_guessing_game_telegram_bot import _Photo
 
 

+ 1 - 0
tests/test_photo_command.py

@@ -18,6 +18,7 @@
 import logging
 import unittest.mock
 
+# pylint: disable=import-private-name; tests
 from location_guessing_game_telegram_bot import _photo_command
 
 

+ 1 - 0
tests/test_run.py

@@ -17,6 +17,7 @@
 
 import unittest.mock
 
+# pylint: disable=import-private-name; tests
 from location_guessing_game_telegram_bot import _run