Преглед изворни кода

Replace some more println with log

Marcus Thiesen пре 9 година
родитељ
комит
b0ea636179
7 измењених фајлова са 16 додато и 13 уклоњено
  1. 2 2
      Cargo.toml
  2. 1 1
      src/audio_backend/portaudio.rs
  3. 1 1
      src/audio_backend/pulseaudio.rs
  4. 2 1
      src/lib.rs
  5. 5 3
      src/main.rs
  6. 4 4
      src/session.rs
  7. 1 1
      src/spirc.rs

+ 2 - 2
Cargo.toml

@@ -33,8 +33,8 @@ rustc-serialize = "~0.3.16"
 tempfile        = "~2.0.0"
 time            = "~0.1.34"
 url             = "~0.5.2"
-log 		= "0.3"
-env_logger 	= "0.3"
+log 		= "0.3.5"
+env_logger 	= "0.3.2"
 shannon         = { git = "https://github.com/plietar/rust-shannon" }
 
 vorbis          = "~0.0.14"

+ 1 - 1
src/audio_backend/portaudio.rs

@@ -30,7 +30,7 @@ impl <'a> Sink for PortAudioSink<'a> {
     fn write(&self, data: &[i16]) -> io::Result<()> {
         match self.0.write(&data) {
             Ok(_) => (),
-            Err(portaudio::PaError::OutputUnderflowed) => eprintln!("Underflow"),
+            Err(portaudio::PaError::OutputUnderflowed) => error!("PortAudio write underflow"),
             Err(e) => panic!("PA Error {}", e),
         };
 

+ 1 - 1
src/audio_backend/pulseaudio.rs

@@ -9,7 +9,7 @@ pub struct PulseAudioSink(*mut pa_simple);
 
 impl Open for PulseAudioSink {
    fn open() -> PulseAudioSink {
-        println!("Using PulseAudioSink");
+        info!("Using PulseAudioSink");
 
         let ss = pa_sample_spec {
             format: PA_SAMPLE_S16LE,

+ 2 - 1
src/lib.rs

@@ -25,7 +25,8 @@ extern crate time;
 extern crate tempfile;
 extern crate url;
 
-#[macro_use] extern crate log;
+#[macro_use]
+extern crate log;
 
 #[cfg(not(feature = "with-tremor"))]
 extern crate vorbis;

+ 5 - 3
src/main.rs

@@ -2,6 +2,8 @@ extern crate getopts;
 extern crate librespot;
 extern crate rpassword;
 extern crate env_logger;
+#[macro_use]
+extern crate log;
 
 use rpassword::read_password;
 use std::clone::Clone;
@@ -34,12 +36,12 @@ static APPKEY: Option<&'static [u8]> = None;
 fn main() {
     let rust_log = "RUST_LOG";
     if let Err(_) = env::var(rust_log) {
-        env::set_var(rust_log, "info")
+        env::set_var(rust_log, "debug")
     }
 
     env_logger::init().unwrap();
 
-    println!("librespot {} ({}). Built on {}.",
+    info!("librespot {} ({}). Built on {}.",
              version::short_sha(),
              version::commit_date(),
              version::short_now());
@@ -150,7 +152,7 @@ fn main() {
     }).or(stored_credentials)
       .or_else(|| {
         if cfg!(feature = "discovery") {
-            println!("No username provided and no stored credentials, starting discovery ...");
+            info!("No username provided and no stored credentials, starting discovery ...");
             Some(discovery_login(&session.config().device_name,
                                  session.device_id()).unwrap())
         } else {

+ 4 - 4
src/session.rs

@@ -95,7 +95,7 @@ impl Session {
         let aps = apresolve().unwrap();
         let ap = thread_rng().choose(&aps).expect("No APs found");
 
-        println!("Connecting to AP {}", ap);
+        info!("Connecting to AP {}", ap);
         let mut connection = PlainConnection::connect(ap).unwrap();
 
         let request = protobuf_init!(protocol::keyexchange::ClientHello::new(), {
@@ -217,7 +217,7 @@ impl Session {
                 *self.0.rx_connection.lock().unwrap() = Some(connection.clone());
                 *self.0.tx_connection.lock().unwrap() = Some(connection);
 
-                eprintln!("Authenticated !");
+                info!("Authenticated !");
 
                 let reusable_credentials = Credentials {
                     username: username,
@@ -231,11 +231,11 @@ impl Session {
             0xad => {
                 let msg: protocol::keyexchange::APLoginFailed =
                     protobuf::parse_from_bytes(&data).unwrap();
-                eprintln!("Authentication failed, {:?}", msg);
+                error!("Authentication failed, {:?}", msg);
                 Err(())
             }
             _ => {
-                println!("Unexpected message {:x}", cmd);
+                error!("Unexpected message {:x}", cmd);
                 Err(())
             }
         }

+ 1 - 1
src/spirc.rs

@@ -100,7 +100,7 @@ impl SpircManager {
             let data = pkt.payload.first().unwrap();
             let frame = protobuf::parse_from_bytes::<protocol::spirc::Frame>(data).unwrap();
 
-            println!("{:?} {} {} {} {}",
+            debug!("{:?} {} {} {} {}",
                      frame.get_typ(),
                      frame.get_device_state().get_name(),
                      frame.get_ident(),