refactor: added power_setting param to _run

.pylintrc

@@ -3,3 +3,7 @@
 disable=bad-continuation, # black
         missing-function-docstring,
         missing-module-docstring
+
+[DESIGN]
+
+max-args=8

intertechno_cc1101_mqtt/__init__.py

@@ -170,6 +170,7 @@ def _run(
     mqtt_username: typing.Optional[str],
     mqtt_password: typing.Optional[str],
     alias_file_path: typing.Optional[pathlib.Path],
+    power_setting: int,
 ) -> None:
     if alias_file_path:
         with alias_file_path.open("r") as alias_file:
@@ -178,9 +179,7 @@ def _run(
         aliases = {}
     # https://pypi.org/project/paho-mqtt/
     mqtt_client = paho.mqtt.client.Client(
-        userdata=_MQTTEventUserData(
-            aliases=aliases, power_setting=intertechno_cc1101.DEFAULT_POWER_SETTING
-        )
+        userdata=_MQTTEventUserData(aliases=aliases, power_setting=power_setting)
     )
     mqtt_client.on_connect = _mqtt_on_connect
     _LOGGER.info("connecting to MQTT broker %s:%d", mqtt_host, mqtt_port)
@@ -246,4 +245,5 @@ def _main() -> None:
         mqtt_username=args.mqtt_username,
         mqtt_password=mqtt_password,
         alias_file_path=args.alias_file_path,
+        power_setting=intertechno_cc1101.DEFAULT_POWER_SETTING,
     )

tests/test_cli.py

@@ -68,6 +68,7 @@ def test__main(
         mqtt_username=expected_username,
         mqtt_password=expected_password,
         alias_file_path=None,
+        power_setting=0xC6,
     )
 
 
@@ -110,6 +111,7 @@ def test__main_password_file(tmpdir, password_file_content, expected_password):
         mqtt_username="me",
         mqtt_password=expected_password,
         alias_file_path=None,
+        power_setting=0xC6,
     )
 
 
@@ -158,4 +160,5 @@ def test__main_alias_file():
         mqtt_username=None,
         mqtt_password=None,
         alias_file_path=pathlib.Path("/etc/intertechno-cc1101-mqtt/aliases.json"),
+        power_setting=0xC6,
     )

tests/test_mqtt.py

@@ -12,7 +12,8 @@ import intertechno_cc1101_mqtt
 
 @pytest.mark.parametrize("mqtt_host", ["mqtt-broker.local"])
 @pytest.mark.parametrize("mqtt_port", [1833])
-def test__run(caplog, mqtt_host, mqtt_port):
+@pytest.mark.parametrize("power_setting", [0xC6, 0x34])
+def test__run(caplog, mqtt_host, mqtt_port, power_setting):
     with unittest.mock.patch(
         "paho.mqtt.client.Client"
     ) as mqtt_client_mock, caplog.at_level(logging.DEBUG):
@@ -22,13 +23,14 @@ def test__run(caplog, mqtt_host, mqtt_port):
             mqtt_username=None,
             mqtt_password=None,
             alias_file_path=None,
+            power_setting=power_setting,
         )
     assert mqtt_client_mock.call_count == 1
     assert not mqtt_client_mock.call_args[0]
     assert set(mqtt_client_mock.call_args[1]) == {"userdata"}
     event_userdata = mqtt_client_mock.call_args[1]["userdata"]
     assert event_userdata.aliases == {}
-    assert event_userdata.power_setting == 0xC6
+    assert event_userdata.power_setting == power_setting
     assert not mqtt_client_mock().username_pw_set.called
     mqtt_client_mock().connect.assert_called_once_with(host=mqtt_host, port=mqtt_port)
     mqtt_client_mock().socket().getpeername.return_value = (mqtt_host, mqtt_port)
@@ -69,6 +71,7 @@ def test__run_authentication(mqtt_host, mqtt_port, mqtt_username, mqtt_password)
             mqtt_username=mqtt_username,
             mqtt_password=mqtt_password,
             alias_file_path=None,
+            power_setting=0xC6,
         )
     assert mqtt_client_mock.call_count == 1
     mqtt_client_mock().username_pw_set.assert_called_once_with(
@@ -88,6 +91,7 @@ def test__run_authentication_missing_username(mqtt_host, mqtt_port, mqtt_passwor
                 mqtt_username=None,
                 mqtt_password=mqtt_password,
                 alias_file_path=None,
+                power_setting=0xC6,
             )
 
 
@@ -107,6 +111,7 @@ def test__run_alias_file_path(caplog, tmp_path, mqtt_host, mqtt_port, aliases):
             mqtt_username=None,
             mqtt_password=None,
             alias_file_path=alias_file_path,
+            power_setting=0xC6,
         )
     assert mqtt_client_mock.call_count == 1
     event_userdata = mqtt_client_mock.call_args[1]["userdata"]