Jelajahi Sumber

fix clang-tidy warning modernize-use-emplace

Fabian Peter Hammerle 6 tahun lalu
induk
melakukan
be11d78277
3 mengubah file dengan 4 tambahan dan 5 penghapusan
  1. 0 1
      .clang-tidy
  2. 2 2
      examples/ReadingSData.cpp
  3. 2 2
      lib/HdfFile.cpp

+ 0 - 1
.clang-tidy

@@ -19,7 +19,6 @@ WarningsAsErrors: >-
   -cppcoreguidelines-pro-type-member-init,
   -cppcoreguidelines-pro-type-vararg,
   -cppcoreguidelines-special-member-functions,
-  -modernize-use-emplace,
   -modernize-use-equals-delete,
   -modernize-use-noexcept,
   -performance-inefficient-vector-operation,

+ 2 - 2
examples/ReadingSData.cpp

@@ -33,9 +33,9 @@ int main() {
     std::vector<int32> dims = item.getDims();
     for (const auto &dim : dims) {
         if (dim >= 1) {
-            ranges.push_back(Range(0, dim - 1));
+            ranges.emplace_back(0, dim - 1);
         } else {
-            ranges.push_back(Range(0, dim));
+            ranges.emplace_back(0, dim);
         }
     }
     item.read(vec, ranges);

+ 2 - 2
lib/HdfFile.cpp

@@ -31,14 +31,14 @@ hdf4cpp::HdfFile::HdfFile(const std::string &path)
     std::vector<int32> refs((size_t)loneSize);
     Vlone(vId, refs.data(), loneSize);
     for (const auto &ref : refs) {
-        loneRefs.push_back(std::pair<int32, Type>(ref, VGROUP));
+        loneRefs.emplace_back(ref, VGROUP);
     }
 
     int32 loneVdata = VSlone(vId, nullptr, 0);
     refs.resize((size_t)loneVdata);
     VSlone(vId, refs.data(), loneVdata);
     for (const auto &ref : refs) {
-        loneRefs.push_back(std::pair<int32, Type>(ref, VDATA));
+        loneRefs.emplace_back(ref, VDATA);
     }
 }
 hdf4cpp::HdfFile::HdfFile(HdfFile &&file)