solving buffer overflow issue, removing the fieldNames member from the vdataitem

include/hdf4cpp/HdfDefines.h

@@ -9,7 +9,7 @@
 #include <hdf/mfhdf.h>
 
 #define MAX_DIMENSION 32
-#define MAX_NAME_LENGTH 100
+#define MAX_NAME_LENGTH 1000
 
 namespace hdf4cpp {
 

include/hdf4cpp/HdfItem.h

@@ -178,7 +178,7 @@ class HdfDataItem : public HdfItemBase {
         }
 
         int32 fieldSize = VSsizeof(id, (char*)field.c_str());
-        if (sizeof(T) < fieldSize) {
+        if (sizeof(T) < (size_t) fieldSize) {
             raiseException(BUFFER_SIZE_NOT_ENOUGH);
         }
 
@@ -242,7 +242,6 @@ class HdfDataItem : public HdfItemBase {
     int32 nrRecords;
     int32 interlace;
     int32 recordSize;
-    std::vector<std::string> fieldNames;
 
     int32 getDataType() const;
 };

lib/HdfItem.cpp

@@ -67,16 +67,10 @@ int32 hdf4cpp::HdfGroupItem::getDataType() const {
     raiseException(INVALID_OPERATION);
 }
 hdf4cpp::HdfDataItem::HdfDataItem(int32 id, const HdfDestroyerChain& chain) : HdfItemBase(id, VDATA, chain) {
-    char fieldNameList[MAX_NAME_LENGTH];
+    this->chain.push_back(new HdfDataItemDestroyer(id));
     char _name[MAX_NAME_LENGTH];
-    VSinquire(id, &nrRecords, &interlace, fieldNameList, &recordSize, _name);
+    VSinquire(id, &nrRecords, &interlace, nullptr, &recordSize, _name);
     name = std::string(_name);
-    std::istringstream in(fieldNameList);
-    std::string token;
-    while(getline(in, token, ',')) {
-        fieldNames.push_back(token);
-    }
-    this->chain.push_back(new HdfDataItemDestroyer(id));
 }
 hdf4cpp::HdfDataItem::~HdfDataItem() {
 }
@@ -90,13 +84,10 @@ std::string hdf4cpp::HdfDataItem::getName() const {
     return name;
 }
 std::vector<int32> hdf4cpp::HdfDataItem::getDims() {
-    std::vector<int32> dims;
-    dims.push_back(nrRecords);
-    dims.push_back((int32) fieldNames.size());
-    return dims;
+    raiseException(INVALID_OPERATION);
 }
 intn hdf4cpp::HdfDataItem::size() const {
-    return nrRecords * (int32) fieldNames.size();
+    raiseException(INVALID_OPERATION);
 }
 int32 hdf4cpp::HdfDataItem::getDataType() const {
     return 0;